Add transaction_id to SEP-12 requests
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
approved these changes
Jun 12, 2024
CassioMG
reviewed
Aug 23, 2024
| ): AddCustomerResponse { | ||
| val customer: MutableMap<String, String> = mutableMapOf() | ||
|
|
||
| populateMap(type, customer, memo, sep9Info) | ||
|
|
||
| val urlBuilder = URLBuilder(baseUrl) | ||
| urlBuilder.appendPathSegments("customer") | ||
| urlBuilder.addParameter("transaction_id", transactionId) |
There was a problem hiding this comment.
@philipliu @Ifropc shouldn't the transaction_id value go in the request body (aka populateMap) instead of a url parameter for this PUT request?
There was a problem hiding this comment.
Thanks for catching this. I'll publish a PR to fix this.
CassioMG
reviewed
Aug 23, 2024
| @@ -116,6 +127,7 @@ internal constructor( | |||
|
|
|||
| val urlBuilder = URLBuilder(baseUrl) | |||
| urlBuilder.appendPathSegments("customer") | |||
| urlBuilder.addParameter("transaction_id", transactionId) | |||
There was a problem hiding this comment.
@philipliu @Ifropc same question here: shouldn't the transaction_id value go in the request body (aka populateMap) instead of a url parameter for this PUT request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the latest version of the SEP-12 protocol. Tests have not been added because the test anchor does not support the
transaction_idfields.